Commit 5f95f003 authored by Srinivasan Shanmugam's avatar Srinivasan Shanmugam Committed by Alex Deucher
Browse files

drm/amdgpu: Cleanup amdgpu/amdgpu_cgs.c 



Fixes the below:

ERROR: switch and case should be at the same indent
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
WARNING: Block comments use * on subsequent lines
WARNING: Comparisons should place the constant on the right side of the test

Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: default avatarGuchun Chen <guchun.chen@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 2d5c0415

drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c

+38 −38
Original line number Diff line number Diff line
@@ -41,13 +41,13 @@ struct amdgpu_cgs_device { 
		((struct amdgpu_cgs_device *)cgs_device)->adev





static uint32_t amdgpu_cgs_read_register(struct cgs_device *cgs_device, unsigned offset)

static uint32_t amdgpu_cgs_read_register(struct cgs_device *cgs_device, unsigned int offset)

{

	CGS_FUNC_ADEV;

	return RREG32(offset);

}



static void amdgpu_cgs_write_register(struct cgs_device *cgs_device, unsigned offset,

static void amdgpu_cgs_write_register(struct cgs_device *cgs_device, unsigned int offset,

				      uint32_t value)

{

	CGS_FUNC_ADEV;
@@ -56,7 +56,7 @@ static void amdgpu_cgs_write_register(struct cgs_device *cgs_device, unsigned of 


static uint32_t amdgpu_cgs_read_ind_register(struct cgs_device *cgs_device,

					     enum cgs_ind_reg space,

					     unsigned index)

					     unsigned int index)

{

	CGS_FUNC_ADEV;

	switch (space) {
@@ -84,7 +84,7 @@ static uint32_t amdgpu_cgs_read_ind_register(struct cgs_device *cgs_device, 


static void amdgpu_cgs_write_ind_register(struct cgs_device *cgs_device,

					  enum cgs_ind_reg space,

					  unsigned index, uint32_t value)

					  unsigned int index, uint32_t value)

{

	CGS_FUNC_ADEV;

	switch (space) {
@@ -205,7 +205,7 @@ static int amdgpu_cgs_get_firmware_info(struct cgs_device *cgs_device, 
{

	CGS_FUNC_ADEV;



	if ((CGS_UCODE_ID_SMU != type) && (CGS_UCODE_ID_SMU_SK != type)) {

	if (type != CGS_UCODE_ID_SMU && type != CGS_UCODE_ID_SMU_SK) {

		uint64_t gpu_addr;

		uint32_t data_size;

		const struct gfx_firmware_header_v1_0 *header;
@@ -232,7 +232,7 @@ static int amdgpu_cgs_get_firmware_info(struct cgs_device *cgs_device, 
		info->mc_addr = gpu_addr;

		info->version = (uint16_t)le32_to_cpu(header->header.ucode_version);



		if (CGS_UCODE_ID_CP_MEC == type)

		if (type == CGS_UCODE_ID_CP_MEC)

			info->image_size = le32_to_cpu(header->jt_offset) << 2;



		info->fw_version = amdgpu_get_firmware_version(cgs_device, type);