Unverified Commit 5e742fb8 authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!4644 f2fs: explicitly null-terminate the xattr list 

Merge Pull Request from: @ci-robot 
 
PR sync from: Zizhi Wo <wozizhi@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/MTNFKI7FUFG7VXRJACUVFNQNLDMQJZER/ 
 
https://gitee.com/src-openeuler/kernel/issues/I92HXK 
 
Link:https://gitee.com/openeuler/kernel/pulls/4644

 

Reviewed-by: default avatarzhangyi (F) <yi.zhang@huawei.com>
Signed-off-by: default avatarZheng Zengkai <zhengzengkai@huawei.com>
parents 0b308045 47bc394f

fs/f2fs/xattr.c

+6 −0
Original line number Diff line number Diff line
@@ -754,6 +754,12 @@ static int __f2fs_setxattr(struct inode *inode, int index, 
		memcpy(pval, value, size);

		last->e_value_size = cpu_to_le16(size);

		new_hsize += newsize;

		/*

		 * Explicitly add the null terminator.  The unused xattr space

		 * is supposed to always be zeroed, which would make this

		 * unnecessary, but don't depend on that.

		 */

		*(u32 *)((u8 *)last + newsize) = 0;

	}



	error = write_all_xattrs(inode, new_hsize, base_addr, ipage);