Unverified Commit 5e4322a8 authored by Zou Wei's avatar Zou Wei Committed by Maxime Ripard
Browse files

drm/vc4: hdmi: Fix PM reference leak in vc4_hdmi_encoder_pre_crtc_co() 



pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZou Wei <zou_wei@huawei.com>
Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/1621840854-105978-1-git-send-email-zou_wei@huawei.com
parent a596fcd9

drivers/gpu/drm/vc4/vc4_hdmi.c

+1 −1
Original line number Diff line number Diff line
@@ -901,7 +901,7 @@ static void vc4_hdmi_encoder_pre_crtc_configure(struct drm_encoder *encoder, 
	unsigned long bvb_rate, pixel_rate, hsm_rate;

	int ret;



	ret = pm_runtime_get_sync(&vc4_hdmi->pdev->dev);

	ret = pm_runtime_resume_and_get(&vc4_hdmi->pdev->dev);

	if (ret < 0) {

		DRM_ERROR("Failed to retain power domain: %d\n", ret);

		return;