Commit a596fcd9 authored by Douglas Anderson's avatar Douglas Anderson
Browse files

drm/panel: panel-simple: Add missing pm_runtime_dont_use_autosuspend() calls 



The PM Runtime docs specifically call out the need to call
pm_runtime_dont_use_autosuspend() in the remove() callback if
pm_runtime_use_autosuspend() was called in probe():

> Drivers in ->remove() callback should undo the runtime PM changes done
> in ->probe(). Usually this means calling pm_runtime_disable(),
> pm_runtime_dont_use_autosuspend() etc.

We should do this. This fixes a warning splat that I saw when I was
testing out the panel-simple's remove().

Fixes: 3235b0f2 ("drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare")
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210517130450.v7.1.I9e947183e95c9bd067c9c1d51208ac6a96385139@changeid
parent 257d36d4

drivers/gpu/drm/panel/panel-simple.c

+2 −0
Original line number Diff line number Diff line
@@ -798,6 +798,7 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) 
	return 0;



disable_pm_runtime:

	pm_runtime_dont_use_autosuspend(dev);

	pm_runtime_disable(dev);

free_ddc:

	if (panel->ddc)
@@ -814,6 +815,7 @@ static int panel_simple_remove(struct device *dev) 
	drm_panel_disable(&panel->base);

	drm_panel_unprepare(&panel->base);



	pm_runtime_dont_use_autosuspend(dev);

	pm_runtime_disable(dev);

	if (panel->ddc)

		put_device(&panel->ddc->dev);