Commit 5d8f3c06 authored by Ondrej Mosnacek's avatar Ondrej Mosnacek Committed by GUO Zihua
Browse files

crypto: algif_aead - fix uninitialized ctx->init

mainline inclusion
from mainline-v5.9-rc1
commit 21dfbcd1
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I991GQ
CVE: NA

Reference: https://github.com/torvalds/linux/commit/21dfbcd1f5cbff9cf2f9e7e43475aed8d072b0dd



--------------------------------

In skcipher_accept_parent_nokey() the whole af_alg_ctx structure is
cleared by memset() after allocation, so add such memset() also to
aead_accept_parent_nokey() so that the new "init" field is also
initialized to zero. Without that the initial ctx->init checks might
randomly return true and cause errors.

While there, also remove the redundant zero assignments in both
functions.

Found via libkcapi testsuite.

Cc: Stephan Mueller <smueller@chronox.de>
Fixes: f3c802a1 ("crypto: algif_aead - Only wake up when ctx->more is zero")
Suggested-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarOndrej Mosnacek <omosnace@redhat.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarGUO Zihua <guozihua@huawei.com>
parent c0f28264
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment