Commit 5b0bb12c authored by Dinghao Liu's avatar Dinghao Liu Committed by Saeed Mahameed
Browse files

net/mlx5e: Fix memleak in mlx5e_create_l2_table_groups 



When mlx5_create_flow_group() fails, ft->g should be
freed just like when kvzalloc() fails. The caller of
mlx5e_create_l2_table_groups() does not catch this
issue on failure, which leads to memleak.

Fixes: 33cfaaa8 ("net/mlx5e: Split the main flow steering table")
Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 7a6eb072

drivers/net/ethernet/mellanox/mlx5/core/en_fs.c

+1 −0
Original line number Diff line number Diff line
@@ -1392,6 +1392,7 @@ static int mlx5e_create_l2_table_groups(struct mlx5e_l2_table *l2_table) 
	ft->g[ft->num_groups] = NULL;

	mlx5e_destroy_groups(ft);

	kvfree(in);

	kfree(ft->g);



	return err;

}