Commit 7a6eb072 authored Dec 28, 2020 by Dinghao Liu Committed by Saeed Mahameed Jan 07, 2021

net/mlx5e: Fix two double free cases



mlx5e_create_ttc_table_groups() frees ft->g on failure of
kvzalloc(), but such failure will be caught by its caller
in mlx5e_create_ttc_table() and ft->g will be freed again
in mlx5e_destroy_flow_table(). The same issue also occurs
in mlx5e_create_ttc_table_groups(). Set ft->g to NULL after
kfree() to avoid double free.

Fixes: 7b3722fa ("net/mlx5e: Support RSS for GRE tunneled packets")
Fixes: 33cfaaa8 ("net/mlx5e: Split the main flow steering table")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>

parent 4d8be211

drivers/net/ethernet/mellanox/mlx5/core/en_fs.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -942,6 +942,7 @@ static int mlx5e_create_ttc_table_groups(struct mlx5e_ttc_table *ttc,
		in = kvzalloc(inlen, GFP_KERNEL);
		if (!in) {
		kfree(ft->g);
		ft->g = NULL;
		return -ENOMEM;
		}

		@@ -1087,6 +1088,7 @@ static int mlx5e_create_inner_ttc_table_groups(struct mlx5e_ttc_table *ttc)
		in = kvzalloc(inlen, GFP_KERNEL);
		if (!in) {
		kfree(ft->g);
		ft->g = NULL;
		return -ENOMEM;
		}