Commit 5ac814e0 authored by Daisuke Matsuda's avatar Daisuke Matsuda Committed by Leon Romanovsky
Browse files

RDMA/rxe: Handle remote errors in the midst of a Read reply sequence 

Requesting nodes do not handle a reported error correctly if it is
generated in the middle of multi-packet Read responses, and the node tries
to resend the request endlessly. Let completer terminate the connection in
that case.

Link: https://lore.kernel.org/r/20221013014724.3786212-2-matsuda-daisuke@fujitsu.com


Signed-off-by: default avatarDaisuke Matsuda <matsuda-daisuke@fujitsu.com>
Reviewed-by: default avatarLi Zhijian <lizhijian@fujitsu.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 5ebc548f

drivers/infiniband/sw/rxe/rxe_comp.c

+8 −0
Original line number Diff line number Diff line
@@ -200,6 +200,10 @@ static inline enum comp_state check_psn(struct rxe_qp *qp, 
		 */

		if (pkt->psn == wqe->last_psn)

			return COMPST_COMP_ACK;

		else if (pkt->opcode == IB_OPCODE_RC_ACKNOWLEDGE &&

			 (qp->comp.opcode == IB_OPCODE_RC_RDMA_READ_RESPONSE_FIRST ||

			  qp->comp.opcode == IB_OPCODE_RC_RDMA_READ_RESPONSE_MIDDLE))

			return COMPST_CHECK_ACK;

		else

			return COMPST_DONE;

	} else if ((diff > 0) && (wqe->mask & WR_ATOMIC_OR_READ_MASK)) {
@@ -228,6 +232,10 @@ static inline enum comp_state check_ack(struct rxe_qp *qp, 


	case IB_OPCODE_RC_RDMA_READ_RESPONSE_FIRST:

	case IB_OPCODE_RC_RDMA_READ_RESPONSE_MIDDLE:

		/* Check NAK code to handle a remote error */

		if (pkt->opcode == IB_OPCODE_RC_ACKNOWLEDGE)

			break;



		if (pkt->opcode != IB_OPCODE_RC_RDMA_READ_RESPONSE_MIDDLE &&

		    pkt->opcode != IB_OPCODE_RC_RDMA_READ_RESPONSE_LAST) {

			/* read retries of partial data may restart from