Commit 5ebc548f authored by Daisuke Matsuda's avatar Daisuke Matsuda Committed by Leon Romanovsky
Browse files

RDMA/rxe: Make responder handle RDMA Read failures 

Currently, responder can reply packets with invalid payloads if it fails
to copy messages to the packets. Add an error handling in read_reply() to
inform a requesting node of the failure.

Link: https://lore.kernel.org/r/20221013014724.3786212-1-matsuda-daisuke@fujitsu.com


Suggested-by: default avatarLi Zhijian <lizhijian@fujitsu.com>
Signed-off-by: default avatarDaisuke Matsuda <matsuda-daisuke@fujitsu.com>
Reviewed-by: default avatarLi Zhijian <lizhijian@fujitsu.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 71d23639

drivers/infiniband/sw/rxe/rxe_resp.c

+6 −2
Original line number Diff line number Diff line
@@ -809,10 +809,14 @@ static enum resp_states read_reply(struct rxe_qp *qp, 
	if (!skb)

		return RESPST_ERR_RNR;



	rxe_mr_copy(mr, res->read.va, payload_addr(&ack_pkt),

	err = rxe_mr_copy(mr, res->read.va, payload_addr(&ack_pkt),

			  payload, RXE_FROM_MR_OBJ);

	if (mr)

		rxe_put(mr);

	if (err) {

		kfree_skb(skb);

		return RESPST_ERR_RKEY_VIOLATION;

	}



	if (bth_pad(&ack_pkt)) {

		u8 *pad = payload_addr(&ack_pkt) + payload;