Commit 5a6bc290 authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Linus Walleij
Browse files

pinctrl: sprd: Add of_node_put() before return to prevent memory leak 



Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return in
two places.
Issue found with Coccinelle.

Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190808074329.15579-1-nishkadg.linux@gmail.com


Reviewed-by: default avatarBaolin Wang <baolin.wang@linaro.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 474137c9

drivers/pinctrl/sprd/pinctrl-sprd.c

+7 −2
Original line number Diff line number Diff line
@@ -925,8 +925,10 @@ static int sprd_pinctrl_parse_dt(struct sprd_pinctrl *sprd_pctl) 


	for_each_child_of_node(np, child) {

		ret = sprd_pinctrl_parse_groups(child, sprd_pctl, grp);

		if (ret)

		if (ret) {

			of_node_put(child);

			return ret;

		}



		*temp++ = grp->name;

		grp++;
@@ -935,8 +937,11 @@ static int sprd_pinctrl_parse_dt(struct sprd_pinctrl *sprd_pctl) 
			for_each_child_of_node(child, sub_child) {

				ret = sprd_pinctrl_parse_groups(sub_child,

								sprd_pctl, grp);

				if (ret)

				if (ret) {

					of_node_put(sub_child);

					of_node_put(child);

					return ret;

				}



				*temp++ = grp->name;

				grp++;