Commit 474137c9 authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Linus Walleij
Browse files

pinctrl: stm32: stm32: Add of_node_put() before return 



Each iteration of for_each_child_of_node and
for_each_available_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return in
two places.
Issue found with Coccinelle.

Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190808075457.16109-1-nishkadg.linux@gmail.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 21b2920f

drivers/pinctrl/stm32/pinctrl-stm32.c

+4 −1
Original line number Diff line number Diff line
@@ -615,6 +615,7 @@ static int stm32_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev, 
				&reserved_maps, num_maps);

		if (ret < 0) {

			pinctrl_utils_free_map(pctldev, *map, *num_maps);

			of_node_put(np);

			return ret;

		}

	}
@@ -1468,8 +1469,10 @@ int stm32_pctl_probe(struct platform_device *pdev) 
	for_each_available_child_of_node(np, child) {

		if (of_property_read_bool(child, "gpio-controller")) {

			ret = stm32_gpiolib_register_bank(pctl, child);

			if (ret)

			if (ret) {

				of_node_put(child);

				return ret;

			}



			pctl->nbanks++;

		}