Commit 596fc8ad authored May 05, 2022 by James Smart Committed by Martin K. Petersen May 10, 2022

scsi: lpfc: Fix dmabuf ptr assignment in lpfc_ct_reject_event()

Upon driver receipt of a CT cmd for type = 0xFA (Management Server) and
subtype = 0x11 (Fabric Device Management Interface), the driver is
responding with garbage CT cmd data when it should send a properly formed
RJT.

The __lpfc_prep_xmit_seq64_s4() routine was using the wrong buffer for the
reject.

Fix by converting the routine to use the buffer specified in the bde within
the wqe rather than the ill-set bmp element.

Link: https://lore.kernel.org/r/20220506035519.50908-6-jsmart2021@gmail.com


Fixes: 61910d6a ("scsi: lpfc: SLI path split: Refactor CT paths")
Co-developed-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent ead76d4c

drivers/scsi/lpfc/lpfc_sli.c

+3 −12

Original line number	Diff line number	Diff line
		@@ -10808,24 +10808,15 @@ __lpfc_sli_prep_xmit_seq64_s4(struct lpfc_iocbq *cmdiocbq,
		{
		union lpfc_wqe128 *wqe;
		struct ulp_bde64 *bpl;
		struct ulp_bde64_le *bde;

		wqe = &cmdiocbq->wqe;
		memset(wqe, 0, sizeof(*wqe));

		/* Words 0 - 2 */
		bpl = (struct ulp_bde64 *)bmp->virt;
		if (cmdiocbq->cmd_flag & (LPFC_IO_LIBDFC \| LPFC_IO_LOOPBACK)) {
		wqe->xmit_sequence.bde.addrHigh = bpl->addrHigh;
		wqe->xmit_sequence.bde.addrLow = bpl->addrLow;
		wqe->xmit_sequence.bde.tus.w = bpl->tus.w;
		} else {
		bde = (struct ulp_bde64_le *)&wqe->xmit_sequence.bde;
		bde->addr_low = cpu_to_le32(putPaddrLow(bmp->phys));
		bde->addr_high = cpu_to_le32(putPaddrHigh(bmp->phys));
		bde->type_size = cpu_to_le32(bpl->tus.f.bdeSize);
		bde->type_size \|= cpu_to_le32(ULP_BDE64_TYPE_BDE_64);
		}

		/* Word 5 */
		bf_set(wqe_ls, &wqe->xmit_sequence.wge_ctl, last_seq);