Commit 560a3164 authored Mar 24, 2022 by Jakob Koschel Committed by Stephen Boyd May 20, 2022

clk: ti: clkctrl: replace usage of found with dedicated list iterator variable

To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].

This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/


Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20220324071019.59483-1-jakobkoschel@gmail.com


Tested-by: Tony Lindgren <tony@atomide.com>
Reviewed-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent 37004db2

drivers/clk/ti/clkctrl.c

+6 −7

Original line number	Diff line number	Diff line
		@@ -232,8 +232,7 @@ static struct clk_hw _ti_omap4_clkctrl_xlate(struct of_phandle_args clkspec,
		void *data)
		{
		struct omap_clkctrl_provider *provider = data;
		struct omap_clkctrl_clk *entry;
		bool found = false;
		struct omap_clkctrl_clk entry = NULL, iter;

		if (clkspec->args_count != 2)
		return ERR_PTR(-EINVAL);
		@@ -241,15 +240,15 @@ static struct clk_hw _ti_omap4_clkctrl_xlate(struct of_phandle_args clkspec,
		pr_debug("%s: looking for %x:%x\n", __func__,
		clkspec->args[0], clkspec->args[1]);

		list_for_each_entry(entry, &provider->clocks, node) {
		if (entry->reg_offset == clkspec->args[0] &&
		entry->bit_offset == clkspec->args[1]) {
		found = true;
		list_for_each_entry(iter, &provider->clocks, node) {
		if (iter->reg_offset == clkspec->args[0] &&
		iter->bit_offset == clkspec->args[1]) {
		entry = iter;
		break;
		}
		}

		if (!found)
		if (!entry)
		return ERR_PTR(-EINVAL);

		return entry->clk;