Commit 37004db2 authored by Len Baker's avatar Len Baker Committed by Stephen Boyd
Browse files

clk: ti: composite: Prefer kcalloc over open coded arithmetic 

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument
size * count in the kzalloc() function.

[1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments



Signed-off-by: default avatarLen Baker <len.baker@gmx.com>
Link: https://lore.kernel.org/r/20210904131714.2312-1-len.baker@gmx.com


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent bae71de5

drivers/clk/ti/composite.c

+1 −1
Original line number Diff line number Diff line
@@ -255,7 +255,7 @@ int __init ti_clk_add_component(struct device_node *node, struct clk_hw *hw, 
		return -EINVAL;

	}



	parent_names = kzalloc((sizeof(char *) * num_parents), GFP_KERNEL);

	parent_names = kcalloc(num_parents, sizeof(char *), GFP_KERNEL);

	if (!parent_names)

		return -ENOMEM;