Commit 55f138db authored by Yang Xingui's avatar Yang Xingui Committed by Yang Yingliang
Browse files

scsi: hisi_sas: Delete down() when handle Block-IO



driver inclusion
category: bugfix
bugzilla: NA
CVE: NA

Call down() at RCU Read-Side Critical Secrion sometimes may
caugh a RCU preempt Calltrace.
[ 3506.800288] rcu: INFO: rcu_preempt detected stalls on CPUs/tasks:
[ 3506.806357] rcu: Tasks blocked on level-1 rcu_node (CPUs 0-15): P22895/1:b..l
[ 3506.813556] (detected by 108, t=162805 jiffies, g=124209, q=59192378)
[ 3506.820056] kworker/0:1H D 0 22895 2 0x00000228
[ 3506.825524] Workqueue: kblockd blk_mq_run_work_fn
[ 3506.830207] Call trace:
[ 3506.832644] __switch_to+0xf0/0x140
[ 3506.836118] __schedule+0x890/0xdc8
[ 3506.839590] schedule+0x80/0x120
[ 3506.842804] schedule_timeout+0x22c/0x328
[ 3506.846796] __down+0x74/0xc8
[ 3506.849751] down+0x54/0x70
[ 3506.852539] hisi_sas_task_exec.isra.25+0x840/0xf28 [hisi_sas_main]
[ 3506.858780] hisi_sas_queue_command+0x40/0x84 [hisi_sas_main]
[ 3506.864502] sas_queuecommand+0x144/0x1c8 [libsas]
[ 3506.869271] scsi_queue_rq+0x72c/0xa20
[ 3506.873005] blk_mq_dispatch_rq_list+0x110/0x680
[ 3506.877601] blk_mq_do_dispatch_sched+0x108/0x148
[ 3506.882285] __blk_mq_sched_dispatch_requests+0x120/0x1b8
[ 3506.887659] blk_mq_sched_dispatch_requests+0x40/0x78
[ 3506.892688] __blk_mq_run_hw_queue+0xb8/0x138
[ 3506.897026] blk_mq_run_work_fn+0x28/0x38
Actually it's no need for keeping IO stopping here to wait for
controller reset complete. We can directly return error code.

Signed-off-by: default avatarYang Xingui <yangxingui@huawei.com>
Reviewed-by: default avatarZhu Xiongxiong <zhuxiongxiong@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
parent 7adf22cc
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment