Commit 525f20b7 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev/pxafb: Use fbdev I/O helpers 



Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
	* use _IOMEM_ in commit message
v2:
	* updated to use _IOMEM_ tokens

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Acked-by: default avatarHelge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-36-tzimmermann@suse.de
parent cc61e67c

drivers/video/fbdev/Kconfig

+1 −3
Original line number Diff line number Diff line
@@ -1580,9 +1580,7 @@ config FB_PXA168 
config FB_PXA

	tristate "PXA LCD framebuffer support"

	depends on FB && ARCH_PXA

	select FB_CFB_FILLRECT

	select FB_CFB_COPYAREA

	select FB_CFB_IMAGEBLIT

	select FB_IOMEM_HELPERS

	select VIDEOMODE_HELPERS if OF

	select FB_MODE_HELPERS if OF

	help

drivers/video/fbdev/pxafb.c

+1 −3
Original line number Diff line number Diff line
@@ -599,13 +599,11 @@ static int pxafb_blank(int blank, struct fb_info *info) 


static const struct fb_ops pxafb_ops = {

	.owner		= THIS_MODULE,

	FB_DEFAULT_IOMEM_OPS,

	.fb_check_var	= pxafb_check_var,

	.fb_set_par	= pxafb_set_par,

	.fb_pan_display	= pxafb_pan_display,

	.fb_setcolreg	= pxafb_setcolreg,

	.fb_fillrect	= cfb_fillrect,

	.fb_copyarea	= cfb_copyarea,

	.fb_imageblit	= cfb_imageblit,

	.fb_blank	= pxafb_blank,

};