Commit cc61e67c authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev/pxa168fb: Use fbdev I/O helpers 



Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
	* use _IOMEM_ in commit message
v2:
	* updated to use _IOMEM_ tokens

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Acked-by: default avatarHelge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-35-tzimmermann@suse.de
parent 711b8025

drivers/video/fbdev/Kconfig

+1 −3
Original line number Diff line number Diff line
@@ -1572,9 +1572,7 @@ config FB_PXA168 
	tristate "PXA168/910 LCD framebuffer support"

	depends on FB && HAVE_CLK && HAS_IOMEM

	depends on CPU_PXA168 || CPU_PXA910 || COMPILE_TEST

	select FB_CFB_FILLRECT

	select FB_CFB_COPYAREA

	select FB_CFB_IMAGEBLIT

	select FB_IOMEM_HELPERS

	help

	  Frame buffer driver for the built-in LCD controller in the Marvell

	  MMP processor.

drivers/video/fbdev/pxa168fb.c

+1 −3
Original line number Diff line number Diff line
@@ -543,14 +543,12 @@ static irqreturn_t pxa168fb_handle_irq(int irq, void *dev_id) 


static const struct fb_ops pxa168fb_ops = {

	.owner		= THIS_MODULE,

	FB_DEFAULT_IOMEM_OPS,

	.fb_check_var	= pxa168fb_check_var,

	.fb_set_par	= pxa168fb_set_par,

	.fb_setcolreg	= pxa168fb_setcolreg,

	.fb_blank	= pxa168fb_blank,

	.fb_pan_display	= pxa168fb_pan_display,

	.fb_fillrect	= cfb_fillrect,

	.fb_copyarea	= cfb_copyarea,

	.fb_imageblit	= cfb_imageblit,

};



static void pxa168fb_init_mode(struct fb_info *info,