Commit 50309845 authored by Jan Kara's avatar Jan Kara Committed by sanglipeng
Browse files

ext4: Fix deadlock during directory rename

stable inclusion
from stable-v5.10.175
commit b113f90204479f55a17295bedf0cc966a60c7a56
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I8711T

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=b113f90204479f55a17295bedf0cc966a60c7a56



--------------------------------

[ Upstream commit 3c92792d ]

As lockdep properly warns, we should not be locking i_rwsem while having
transactions started as the proper lock ordering used by all directory
handling operations is i_rwsem -> transaction start. Fix the lock
ordering by moving the locking of the directory earlier in
ext4_rename().

Reported-by: default avatar <syzbot+9d16c39efb5fade84574@syzkaller.appspotmail.com>
Fixes: 0813299c ("ext4: Fix possible corruption when moving a directory")
Link: https://syzkaller.appspot.com/bug?extid=9d16c39efb5fade84574


Signed-off-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230301141004.15087-1-jack@suse.cz


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarsanglipeng <sanglipeng1@jd.com>
parent d2e413f5
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment