x86/show_trace_log_lvl: Ensure stack pointer is aligned, again
stable inclusion from stable-v5.10.181 commit c966b58c8515b2d6720ddf7b327b4ba5d9ba89a2 category: bugfix bugzilla: https://gitee.com/openeuler/kernel/issues/I8GJZJ Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=c966b58c8515b2d6720ddf7b327b4ba5d9ba89a2 -------------------------------- commit 2e4be0d0 upstream. The commit e335bb51 ("x86/unwind: Ensure stack pointer is aligned") tried to align the stack pointer in show_trace_log_lvl(), otherwise the "stack < stack_info.end" check can't guarantee that the last read does not go past the end of the stack. However, we have the same problem with the initial value of the stack pointer, it can also be unaligned. So without this patch this trivial kernel module #include <linux/module.h> static int init(void) { asm volatile("sub $0x4,%rsp"); dump_stack(); asm volatile("add $0x4,%rsp"); return -EAGAIN; } module_init(init); MODULE_LICENSE("GPL"); crashes the kernel. Fixes: e335bb51 ("x86/unwind: Ensure stack pointer is aligned") Signed-off-by:Vernon Lovejoy <vlovejoy@redhat.com> Signed-off-by:
Oleg Nesterov <oleg@redhat.com> Link: https://lore.kernel.org/r/20230512104232.GA10227@redhat.com Signed-off-by:
Josh Poimboeuf <jpoimboe@kernel.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
sanglipeng <sanglipeng1@jd.com> (cherry picked from commit dbf77dcc)
Loading
Please sign in to comment