Commit 4e705946 authored by Lareine Khawaly's avatar Lareine Khawaly Committed by sanglipeng
Browse files

i2c: designware: use casting of u64 in clock multiplication to avoid overflow

stable inclusion
from stable-v5.10.166
commit ed173f77fd28a3e4fffc13b3f28687b9eba61157
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I87FRA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=ed173f77fd28a3e4fffc13b3f28687b9eba61157



--------------------------------

[ Upstream commit c8c37bc5 ]

In functions i2c_dw_scl_lcnt() and i2c_dw_scl_hcnt() may have overflow
by depending on the values of the given parameters including the ic_clk.
For example in our use case where ic_clk is larger than one million,
multiplication of ic_clk * 4700 will result in 32 bit overflow.

Add cast of u64 to the calculation to avoid multiplication overflow, and
use the corresponding define for divide.

Fixes: 2373f6b9 ("i2c-designware: split of i2c-designware.c into core and bus specific parts")
Signed-off-by: default avatarLareine Khawaly <lareine@amazon.com>
Signed-off-by: default avatarHanna Hawa <hhhawa@amazon.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: default avatarJarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarsanglipeng <sanglipeng1@jd.com>
parent 9438f4ff
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment