Commit 4e62671a authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen
Browse files

scsi: megaraid: Remove redundant assignment to variable mfiStatus 

The variable mfiStatus is assigned a value but it is never read. The
assignment is redundant and can be removed. Also remove { } as the return
statement does not need to be in its own code block.

Cleans up clang scan build warning:

drivers/scsi/megaraid/megaraid_sas_base.c:4026:7: warning: Although the
value stored to 'mfiStatus' is used in the enclosing expression, the
value is never actually read from 'mfiStatus' [deadcode.DeadStores]

Link: https://lore.kernel.org/r/20220805115042.2340400-1-colin.i.king@gmail.com


Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 3fa5975b

drivers/scsi/megaraid/megaraid_sas_base.c

+1 −3
Original line number Diff line number Diff line
@@ -4023,10 +4023,8 @@ megasas_deplete_reply_queue(struct megasas_instance *instance, 
	u32 mfiStatus;

	u32 fw_state;



	if ((mfiStatus = instance->instancet->check_reset(instance,

					instance->reg_set)) == 1) {

	if (instance->instancet->check_reset(instance, instance->reg_set) == 1)

		return IRQ_HANDLED;

	}



	mfiStatus = instance->instancet->clear_intr(instance);

	if (mfiStatus == 0) {