Commit 3fa5975b authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen
Browse files

scsi: initio: Remove redundant assignment to pointer scb 

The variable scb is assigned a value but it is never read. The assignment
is redundant and can be removed. Also replace the != NULL check with the
more usual non-null check idiom.

Cleans up clang scan build warning:

drivers/scsi/initio.c:1169:9: warning: Although the value stored to 'scb'
is used in the enclosing expression, the value is never actually read
from 'scb' [deadcode.DeadStores]

Link: https://lore.kernel.org/r/20220805114100.2339637-1-colin.i.king@gmail.com


Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 231159f3

drivers/scsi/initio.c

+1 −1
Original line number Diff line number Diff line
@@ -1166,7 +1166,7 @@ static void tulip_scsi(struct initio_host * host) 
			return;

		}

		if (host->jsint & (TSS_FUNC_COMP | TSS_BUS_SERV)) {	/* func complete or Bus service */

			if ((scb = host->active) != NULL)

			if (host->active)

				initio_next_state(host);

			return;

		}