Commit 4a606ce6 authored by Zhang Changzhong's avatar Zhang Changzhong Committed by Tony Nguyen
Browse files

ice: switch: fix potential memleak in ice_add_adv_recipe() 



When ice_add_special_words() fails, the 'rm' is not released, which will
lead to a memory leak. Fix this up by going to 'err_unroll' label.

Compile tested only.

Fixes: 8b032a55 ("ice: low level support for tunnels")
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
Tested-by: default avatarSujai Buvaneswaran <sujai.buvaneswaran@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
parent 3f4870df

drivers/net/ethernet/intel/ice/ice_switch.c

+1 −1
Original line number Diff line number Diff line
@@ -5420,7 +5420,7 @@ ice_add_adv_recipe(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups, 
	 */

	status = ice_add_special_words(rinfo, lkup_exts, ice_is_dvm_ena(hw));

	if (status)

		goto err_free_lkup_exts;

		goto err_unroll;



	/* Group match words into recipes using preferred recipe grouping

	 * criteria.