Commit 3f4870df authored by Dan Carpenter's avatar Dan Carpenter Committed by Tony Nguyen
Browse files

ice: Fix off by one in ice_tc_forward_to_queue()



The > comparison should be >= to prevent reading one element beyond
the end of the array.

The "vsi->num_rxq" is not strictly speaking the number of elements in
the vsi->rxq_map[] array.  The array has "vsi->alloc_rxq" elements and
"vsi->num_rxq" is less than or equal to the number of elements in the
array.  The array is allocated in ice_vsi_alloc_arrays().  It's still
an off by one but it might not access outside the end of the array.

Fixes: 143b86f3 ("ice: Enable RX queue selection using skbedit action")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarAmritha Nambiar <amritha.nambiar@intel.com>
Tested-by: default avatarBharathi Sreenivas <bharathi.sreenivas@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
parent c793f8ea
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -1681,7 +1681,7 @@ ice_tc_forward_to_queue(struct ice_vsi *vsi, struct ice_tc_flower_fltr *fltr,
	struct ice_vsi *ch_vsi = NULL;
	u16 queue = act->rx_queue;

	if (queue > vsi->num_rxq) {
	if (queue >= vsi->num_rxq) {
		NL_SET_ERR_MSG_MOD(fltr->extack,
				   "Unable to add filter because specified queue is invalid");
		return -EINVAL;