Commit 49a46731 authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Vinod Koul
Browse files

soundwire: qcom: check for outanding writes before doing a read 



Reading will increase the fifo count, so check for outstanding cmd wrt.
write fifo depth to avoid overflow as read will also increase
write fifo cnt.

Fixes: a661308c ("soundwire: qcom: wait for fifo space to be available before read/write")
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20221026110210.6575-3-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent f936fa7a

drivers/soundwire/qcom.c

+6 −0
Original line number Diff line number Diff line
@@ -380,6 +380,12 @@ static int qcom_swrm_cmd_fifo_rd_cmd(struct qcom_swrm_ctrl *swrm, 


	val = swrm_get_packed_reg_val(&swrm->rcmd_id, len, dev_addr, reg_addr);



	/*

	 * Check for outstanding cmd wrt. write fifo depth to avoid

	 * overflow as read will also increase write fifo cnt.

	 */

	swrm_wait_for_wr_fifo_avail(swrm);



	/* wait for FIFO RD to complete to avoid overflow */

	usleep_range(100, 105);

	swrm->reg_write(swrm, SWRM_CMD_FIFO_RD_CMD, val);