Commit f936fa7a authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Vinod Koul
Browse files

soundwire: qcom: reinit broadcast completion 



For some reason we never reinit the broadcast completion, there is a
danger that broadcast commands could be treated as completed by driver
from previous complete status.
Fix this by reinitializing the completion before sending a broadcast command.

Fixes: ddea6cf7 ("soundwire: qcom: update register read/write routine")
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20221026110210.6575-2-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 13c30a75

drivers/soundwire/qcom.c

+3 −0
Original line number Diff line number Diff line
@@ -344,6 +344,9 @@ static int qcom_swrm_cmd_fifo_wr_cmd(struct qcom_swrm_ctrl *swrm, u8 cmd_data, 
	if (swrm_wait_for_wr_fifo_avail(swrm))

		return SDW_CMD_FAIL_OTHER;



	if (cmd_id == SWR_BROADCAST_CMD_ID)

		reinit_completion(&swrm->broadcast);



	/* Its assumed that write is okay as we do not get any status back */

	swrm->reg_write(swrm, SWRM_CMD_FIFO_WR_CMD, val);