Commit 4924c0cd authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Jakub Kicinski
Browse files

net: ravb: Fix PHY state warning splat during system resume 



Since commit 744d23c7 ("net: phy: Warn about incorrect
mdio_bus_phy_resume() state"), a warning splat is printed during system
resume with Wake-on-LAN disabled:

        WARNING: CPU: 0 PID: 1197 at drivers/net/phy/phy_device.c:323 mdio_bus_phy_resume+0xbc/0xc8

As the Renesas Ethernet AVB driver already calls phy_{stop,start}() in
its suspend/resume callbacks, it is sufficient to just mark the MAC
responsible for managing the power state of the PHY.

Fixes: fba863b8 ("net: phy: make PHY PM ops a no-op if MAC driver manages PHY PM")
Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Reviewed-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Link: https://lore.kernel.org/r/8ec796f47620980fdd0403e21bd8b7200b4fa1d4.1663598796.git.geert+renesas@glider.be


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 603ccb3a

drivers/net/ethernet/renesas/ravb_main.c

+2 −0
Original line number Diff line number Diff line
@@ -1449,6 +1449,8 @@ static int ravb_phy_init(struct net_device *ndev) 
		phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_100baseT_Half_BIT);

	}



	/* Indicate that the MAC is responsible for managing PHY PM */

	phydev->mac_managed_pm = true;

	phy_attached_info(phydev);



	return 0;