Commit 744d23c7 authored by Florian Fainelli's avatar Florian Fainelli Committed by Jakub Kicinski
Browse files

net: phy: Warn about incorrect mdio_bus_phy_resume() state 



Calling mdio_bus_phy_resume() with neither the PHY state machine set to
PHY_HALTED nor phydev->mac_managed_pm set to true is a good indication
that we can produce a race condition looking like this:

CPU0						CPU1
bcmgenet_resume
 -> phy_resume
   -> phy_init_hw
 -> phy_start
   -> phy_resume
                                                phy_start_aneg()
mdio_bus_phy_resume
 -> phy_resume
    -> phy_write(..., BMCR_RESET)
     -> usleep()                                  -> phy_read()

with the phy_resume() function triggering a PHY behavior that might have
to be worked around with (see bf8bfc43 ("net: phy: broadcom: Fix
brcm_fet_config_init()") for instance) that ultimately leads to an error
reading from the PHY.

Fixes: fba863b8 ("net: phy: make PHY PM ops a no-op if MAC driver manages PHY PM")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20220801233403.258871-1-f.fainelli@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 7de196a6

drivers/net/phy/phy_device.c

+6 −0
Original line number Diff line number Diff line
@@ -316,6 +316,12 @@ static __maybe_unused int mdio_bus_phy_resume(struct device *dev) 


	phydev->suspended_by_mdio_bus = 0;



	/* If we managed to get here with the PHY state machine in a state other

	 * than PHY_HALTED this is an indication that something went wrong and

	 * we should most likely be using MAC managed PM and we are not.

	 */

	WARN_ON(phydev->state != PHY_HALTED && !phydev->mac_managed_pm);



	ret = phy_init_hw(phydev);

	if (ret < 0)

		return ret;