Commit 46ebd4d8 authored by Yangtao Li's avatar Yangtao Li Committed by Viresh Kumar
Browse files

cpufreq: raspberrypi: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarYangtao Li <frank.li@vivo.com>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent 463ff6d4

drivers/cpufreq/raspberrypi-cpufreq.c

+2 −4
Original line number Diff line number Diff line
@@ -65,7 +65,7 @@ static int raspberrypi_cpufreq_probe(struct platform_device *pdev) 
	return ret;

}



static int raspberrypi_cpufreq_remove(struct platform_device *pdev)

static void raspberrypi_cpufreq_remove(struct platform_device *pdev)

{

	struct device *cpu_dev;
@@ -74,8 +74,6 @@ static int raspberrypi_cpufreq_remove(struct platform_device *pdev) 
		dev_pm_opp_remove_all_dynamic(cpu_dev);



	platform_device_unregister(cpufreq_dt);



	return 0;

}



/*
@@ -87,7 +85,7 @@ static struct platform_driver raspberrypi_cpufreq_driver = { 
		.name = "raspberrypi-cpufreq",

	},

	.probe          = raspberrypi_cpufreq_probe,

	.remove		= raspberrypi_cpufreq_remove,

	.remove_new	= raspberrypi_cpufreq_remove,

};

module_platform_driver(raspberrypi_cpufreq_driver);