Commit 463ff6d4 authored by Yangtao Li's avatar Yangtao Li Committed by Viresh Kumar
Browse files

cpufreq: davinci: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarYangtao Li <frank.li@vivo.com>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent 8d09c46a

drivers/cpufreq/davinci-cpufreq.c

+2 −4
Original line number Diff line number Diff line
@@ -131,7 +131,7 @@ static int __init davinci_cpufreq_probe(struct platform_device *pdev) 
	return cpufreq_register_driver(&davinci_driver);

}



static int __exit davinci_cpufreq_remove(struct platform_device *pdev)

static void __exit davinci_cpufreq_remove(struct platform_device *pdev)

{

	cpufreq_unregister_driver(&davinci_driver);
@@ -139,15 +139,13 @@ static int __exit davinci_cpufreq_remove(struct platform_device *pdev) 


	if (cpufreq.asyncclk)

		clk_put(cpufreq.asyncclk);



	return 0;

}



static struct platform_driver davinci_cpufreq_driver = {

	.driver = {

		.name	 = "cpufreq-davinci",

	},

	.remove = __exit_p(davinci_cpufreq_remove),

	.remove_new = __exit_p(davinci_cpufreq_remove),

};



int __init davinci_cpufreq_init(void)