Skip to content
Commit 45e02b88 authored by Miko Larsson's avatar Miko Larsson Committed by Zheng Yejian
Browse files

net/usb: kalmia: Don't pass act_len in usb_bulk_msg error path

stable inclusion
from stable-v4.19.273
commit 723ef7b66f37c0841f5a451ccbce47ee1641e081
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/I9R4LE
CVE: CVE-2023-52703

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=723ef7b66f37c0841f5a451ccbce47ee1641e081

--------------------------------

commit c68f345b upstream.

syzbot reported that act_len in kalmia_send_init_packet() is
uninitialized when passing it to the first usb_bulk_msg error path. Jiri
Pirko noted that it's pointless to pass it in the error path, and that
the value that would be printed in the second error path would be the
value of act_len from the first call to usb_bulk_msg.[1]

With this in mind, let's just not pass act_len to the usb_bulk_msg error
paths.

1: https://lore.kernel.org/lkml/Y9pY61y1nwTuzMOa@nanopsycho/



Fixes: d4026123 ("net/usb: Add Samsung Kalmia driver for Samsung GT-B3730")
Reported-and-tested-by: default avatar <syzbot+cd80c5ef5121bfe85b55@syzkaller.appspotmail.com>
Signed-off-by: default avatarMiko Larsson <mikoxyzzz@gmail.com>
Reviewed-by: default avatarAlexander Duyck <alexanderduyck@fb.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarZheng Yejian <zhengyejian1@huawei.com>
parent aec28351
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment