Commit 45ce0859 authored by Magnus Karlsson's avatar Magnus Karlsson Committed by Tony Nguyen
Browse files

igc: add correct exception tracing for XDP 



Add missing exception tracing to XDP when a number of different
errors can occur. The support was only partial. Several errors
where not logged which would confuse the user quite a lot not
knowing where and why the packets disappeared.

Fixes: 73f1071c ("igc: Add support for XDP_TX action")
Fixes: 4ff32036 ("igc: Add support for XDP_REDIRECT action")
Reported-by: default avatarJesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: default avatarMagnus Karlsson <magnus.karlsson@intel.com>
Tested-by: default avatarDvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent faae8142

drivers/net/ethernet/intel/igc/igc_main.c

+5 −6
Original line number Diff line number Diff line
@@ -2047,20 +2047,19 @@ static struct sk_buff *igc_xdp_run_prog(struct igc_adapter *adapter, 
		break;

	case XDP_TX:

		if (igc_xdp_xmit_back(adapter, xdp) < 0)

			res = IGC_XDP_CONSUMED;

		else

			goto out_failure;

		res = IGC_XDP_TX;

		break;

	case XDP_REDIRECT:

		if (xdp_do_redirect(adapter->netdev, xdp, prog) < 0)

			res = IGC_XDP_CONSUMED;

		else

			goto out_failure;

		res = IGC_XDP_REDIRECT;

		break;

	default:

		bpf_warn_invalid_xdp_action(act);

		fallthrough;

	case XDP_ABORTED:

out_failure:

		trace_xdp_exception(adapter->netdev, prog, act);

		fallthrough;

	case XDP_DROP: