Unverified Commit 45c0cba7 authored by Zhang Qilong's avatar Zhang Qilong Committed by Mark Brown
Browse files

spi: spi-ti-qspi: fix reference leak in ti_qspi_setup 



pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in ti_qspi_setup, so we should fix it.

Fixes: 505a1495 ("spi/qspi: Add qspi flash controller")
Signed-off-by: default avatarZhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201103140947.3815-1-zhangqilong3@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 88e1419b

drivers/spi/spi-ti-qspi.c

+1 −0
Original line number Diff line number Diff line
@@ -174,6 +174,7 @@ static int ti_qspi_setup(struct spi_device *spi) 


	ret = pm_runtime_get_sync(qspi->dev);

	if (ret < 0) {

		pm_runtime_put_noidle(qspi->dev);

		dev_err(qspi->dev, "pm_runtime_get_sync() failed\n");

		return ret;

	}