Unverified Commit 88e1419b authored by Zhang Qilong's avatar Zhang Qilong Committed by Mark Brown
Browse files

spi: stm32-qspi: fix reference leak in stm32 qspi operations 



pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in two callers(stm32_qspi_exec_op and
stm32_qspi_setup), so we should fix it.

Fixes: 9d282c17 ("spi: stm32-qspi: Add pm_runtime support")
Signed-off-by: default avatarZhang Qilong <zhangqilong3@huawei.com>
Reviewed-by: default avatarPatrice Chotard <patrice.chotard@st.com>
Link: https://lore.kernel.org/r/20201106015357.141235-1-zhangqilong3@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 900ccdcb

drivers/spi/spi-stm32-qspi.c

+6 −2
Original line number Diff line number Diff line
@@ -434,8 +434,10 @@ static int stm32_qspi_exec_op(struct spi_mem *mem, const struct spi_mem_op *op) 
	int ret;



	ret = pm_runtime_get_sync(qspi->dev);

	if (ret < 0)

	if (ret < 0) {

		pm_runtime_put_noidle(qspi->dev);

		return ret;

	}



	mutex_lock(&qspi->lock);

	ret = stm32_qspi_send(mem, op);
@@ -462,8 +464,10 @@ static int stm32_qspi_setup(struct spi_device *spi) 
		return -EINVAL;



	ret = pm_runtime_get_sync(qspi->dev);

	if (ret < 0)

	if (ret < 0) {

		pm_runtime_put_noidle(qspi->dev);

		return ret;

	}



	presc = DIV_ROUND_UP(qspi->clk_rate, spi->max_speed_hz) - 1;