Commit 44f331a6 authored by Sagi Grimberg's avatar Sagi Grimberg Committed by Christoph Hellwig
Browse files

nvmet-tcp: replace ida_simple[get|remove] with the simler ida_[alloc|free] 



ida_simple_[get|remove] are wrappers anyways.

Signed-off-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarKeith Busch <kbusch@kernel.org>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 7c256639

drivers/nvme/target/tcp.c

+3 −3
Original line number Diff line number Diff line
@@ -1473,7 +1473,7 @@ static void nvmet_tcp_release_queue_work(struct work_struct *w) 
	nvmet_tcp_free_cmds(queue);

	if (queue->hdr_digest || queue->data_digest)

		nvmet_tcp_free_crypto(queue);

	ida_simple_remove(&nvmet_tcp_queue_ida, queue->idx);

	ida_free(&nvmet_tcp_queue_ida, queue->idx);



	page = virt_to_head_page(queue->pf_cache.va);

	__page_frag_cache_drain(page, queue->pf_cache.pagecnt_bias);
@@ -1613,7 +1613,7 @@ static int nvmet_tcp_alloc_queue(struct nvmet_tcp_port *port, 
	init_llist_head(&queue->resp_list);

	INIT_LIST_HEAD(&queue->resp_send_list);



	queue->idx = ida_simple_get(&nvmet_tcp_queue_ida, 0, 0, GFP_KERNEL);

	queue->idx = ida_alloc(&nvmet_tcp_queue_ida, GFP_KERNEL);

	if (queue->idx < 0) {

		ret = queue->idx;

		goto out_free_queue;
@@ -1646,7 +1646,7 @@ static int nvmet_tcp_alloc_queue(struct nvmet_tcp_port *port, 
out_free_connect:

	nvmet_tcp_free_cmd(&queue->connect);

out_ida_remove:

	ida_simple_remove(&nvmet_tcp_queue_ida, queue->idx);

	ida_free(&nvmet_tcp_queue_ida, queue->idx);

out_free_queue:

	kfree(queue);

	return ret;