Commit 7c256639 authored by Sagi Grimberg's avatar Sagi Grimberg Committed by Christoph Hellwig
Browse files

nvmet-rdma: replace ida_simple[get|remove] with the simler ida_[alloc|free] 



ida_simple_[get|remove] are wrappers anyways.

Signed-off-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarKeith Busch <kbusch@kernel.org>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 6dd0f465

drivers/nvme/target/rdma.c

+3 −3
Original line number Diff line number Diff line
@@ -1356,7 +1356,7 @@ static void nvmet_rdma_free_queue(struct nvmet_rdma_queue *queue) 
				!queue->host_qid);

	}

	nvmet_rdma_free_rsps(queue);

	ida_simple_remove(&nvmet_rdma_queue_ida, queue->idx);

	ida_free(&nvmet_rdma_queue_ida, queue->idx);

	kfree(queue);

}
@@ -1459,7 +1459,7 @@ nvmet_rdma_alloc_queue(struct nvmet_rdma_device *ndev, 
	spin_lock_init(&queue->rsps_lock);

	INIT_LIST_HEAD(&queue->queue_list);



	queue->idx = ida_simple_get(&nvmet_rdma_queue_ida, 0, 0, GFP_KERNEL);

	queue->idx = ida_alloc(&nvmet_rdma_queue_ida, GFP_KERNEL);

	if (queue->idx < 0) {

		ret = NVME_RDMA_CM_NO_RSC;

		goto out_destroy_sq;
@@ -1510,7 +1510,7 @@ nvmet_rdma_alloc_queue(struct nvmet_rdma_device *ndev, 
out_free_responses:

	nvmet_rdma_free_rsps(queue);

out_ida_remove:

	ida_simple_remove(&nvmet_rdma_queue_ida, queue->idx);

	ida_free(&nvmet_rdma_queue_ida, queue->idx);

out_destroy_sq:

	nvmet_sq_destroy(&queue->nvme_sq);

out_free_queue: