Commit 433e3aa3 authored by Ondrej Mosnacek's avatar Ondrej Mosnacek Committed by Paul Moore
Browse files

selinux: drop unnecessary smp_load_acquire() call 



In commit 66f8e2f0 ("selinux: sidtab reverse lookup hash table") the
corresponding load is moved under the spin lock, so there is no race
possible and we can read the count directly. The smp_store_release() is
still needed to avoid racing with the lock-free readers.

Signed-off-by: default avatarOndrej Mosnacek <omosnace@redhat.com>
Signed-off-by: default avatarPaul Moore <paul@paul-moore.com>
parent 4b850396

security/selinux/ss/sidtab.c

+1 −2
Original line number Diff line number Diff line
@@ -276,8 +276,7 @@ int sidtab_context_to_sid(struct sidtab *s, struct context *context, 
	if (*sid)

		goto out_unlock;



	/* read entries only after reading count */

	count = smp_load_acquire(&s->count);

	count = s->count;

	convert = s->convert;



	/* bail out if we already reached max entries */