Commit 4b850396 authored Apr 14, 2020 by Zou Wei Committed by Paul Moore Apr 14, 2020

selinux: fix warning Comparison to bool



fix below warnings reported by coccicheck

security/selinux/ss/mls.c:539:39-43: WARNING: Comparison to bool
security/selinux/ss/services.c:1815:46-50: WARNING: Comparison to bool
security/selinux/ss/services.c:1827:46-50: WARNING: Comparison to bool

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>

parent 8f3d9f35

security/selinux/ss/mls.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -536,7 +536,7 @@ int mls_compute_sid(struct policydb *p,

		/* Fallthrough */
		case AVTAB_CHANGE:
		if ((tclass == p->process_class) \|\| (sock == true))
		if ((tclass == p->process_class) \|\| sock)
		/* Use the process MLS attributes. */
		return mls_context_cpy(newcontext, scontext);
		else

security/selinux/ss/services.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1812,7 +1812,7 @@ static int security_compute_sid(struct selinux_state *state,
		} else if (cladatum && cladatum->default_role == DEFAULT_TARGET) {
		newcontext.role = tcontext->role;
		} else {
		if ((tclass == policydb->process_class) \|\| (sock == true))
		if ((tclass == policydb->process_class) \|\| sock)
		newcontext.role = scontext->role;
		else
		newcontext.role = OBJECT_R_VAL;
		@@ -1824,7 +1824,7 @@ static int security_compute_sid(struct selinux_state *state,
		} else if (cladatum && cladatum->default_type == DEFAULT_TARGET) {
		newcontext.type = tcontext->type;
		} else {
		if ((tclass == policydb->process_class) \|\| (sock == true)) {
		if ((tclass == policydb->process_class) \|\| sock) {
		/* Use the type of process. */
		newcontext.type = scontext->type;
		} else {