Commit 426b6742 authored by Paul Cercueil's avatar Paul Cercueil Committed by Andi Shyti
Browse files

i2c: sh-mobile: Remove #ifdef guards for PM related functions 



Use the new PM macros for the suspend and resume functions to be
automatically dropped by the compiler when CONFIG_PM or
CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.

Signed-off-by: default avatarPaul Cercueil <paul@crapouillou.net>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20230722115310.27681-4-paul@crapouillou.net


Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
parent 67cd4351

drivers/i2c/busses/i2c-sh_mobile.c

+3 −9
Original line number Diff line number Diff line
@@ -965,7 +965,6 @@ static void sh_mobile_i2c_remove(struct platform_device *dev) 
	pm_runtime_disable(&dev->dev);

}



#ifdef CONFIG_PM_SLEEP

static int sh_mobile_i2c_suspend(struct device *dev)

{

	struct sh_mobile_i2c_data *pd = dev_get_drvdata(dev);
@@ -983,20 +982,15 @@ static int sh_mobile_i2c_resume(struct device *dev) 
}



static const struct dev_pm_ops sh_mobile_i2c_pm_ops = {

	SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(sh_mobile_i2c_suspend,

	NOIRQ_SYSTEM_SLEEP_PM_OPS(sh_mobile_i2c_suspend,

				  sh_mobile_i2c_resume)

};



#define DEV_PM_OPS (&sh_mobile_i2c_pm_ops)

#else

#define DEV_PM_OPS NULL

#endif /* CONFIG_PM_SLEEP */



static struct platform_driver sh_mobile_i2c_driver = {

	.driver		= {

		.name		= "i2c-sh_mobile",

		.of_match_table = sh_mobile_i2c_dt_ids,

		.pm	= DEV_PM_OPS,

		.pm	= pm_sleep_ptr(&sh_mobile_i2c_pm_ops),

	},

	.probe		= sh_mobile_i2c_probe,

	.remove_new	= sh_mobile_i2c_remove,