Commit 67cd4351 authored by Paul Cercueil's avatar Paul Cercueil Committed by Andi Shyti
Browse files

i2c: s3c2410: Remove #ifdef guards for PM related functions 



Use the new PM macros for the suspend and resume functions to be
automatically dropped by the compiler when CONFIG_PM or
CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.

Signed-off-by: default avatarPaul Cercueil <paul@crapouillou.net>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20230722115310.27681-3-paul@crapouillou.net


Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
parent 941b99ac

drivers/i2c/busses/i2c-s3c2410.c

+3 −11
Original line number Diff line number Diff line
@@ -1124,7 +1124,6 @@ static void s3c24xx_i2c_remove(struct platform_device *pdev) 
	i2c_del_adapter(&i2c->adap);

}



#ifdef CONFIG_PM_SLEEP

static int s3c24xx_i2c_suspend_noirq(struct device *dev)

{

	struct s3c24xx_i2c *i2c = dev_get_drvdata(dev);
@@ -1154,26 +1153,19 @@ static int s3c24xx_i2c_resume_noirq(struct device *dev) 


	return 0;

}

#endif



#ifdef CONFIG_PM

static const struct dev_pm_ops s3c24xx_i2c_dev_pm_ops = {

	SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(s3c24xx_i2c_suspend_noirq,

	NOIRQ_SYSTEM_SLEEP_PM_OPS(s3c24xx_i2c_suspend_noirq,

				  s3c24xx_i2c_resume_noirq)

};



#define S3C24XX_DEV_PM_OPS (&s3c24xx_i2c_dev_pm_ops)

#else

#define S3C24XX_DEV_PM_OPS NULL

#endif



static struct platform_driver s3c24xx_i2c_driver = {

	.probe		= s3c24xx_i2c_probe,

	.remove_new	= s3c24xx_i2c_remove,

	.id_table	= s3c24xx_driver_ids,

	.driver		= {

		.name	= "s3c-i2c",

		.pm	= S3C24XX_DEV_PM_OPS,

		.pm	= pm_sleep_ptr(&s3c24xx_i2c_dev_pm_ops),

		.of_match_table = of_match_ptr(s3c24xx_i2c_match),

	},

};