Commit 3df55cd7 authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

media: platform: mediatek: vpu: fix NULL ptr dereference 



If pdev is NULL, then it is still dereferenced.

This fixes this smatch warning:

drivers/media/platform/mediatek/vpu/mtk_vpu.c:570 vpu_load_firmware() warn: address of NULL pointer 'pdev'

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Yunfei Dong <yunfei.dong@mediatek.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 99f9cd2e

drivers/media/platform/mediatek/vpu/mtk_vpu.c

+4 −2
Original line number Diff line number Diff line
@@ -562,15 +562,17 @@ static int load_requested_vpu(struct mtk_vpu *vpu, 
int vpu_load_firmware(struct platform_device *pdev)

{

	struct mtk_vpu *vpu;

	struct device *dev = &pdev->dev;

	struct device *dev;

	struct vpu_run *run;

	int ret;



	if (!pdev) {

		dev_err(dev, "VPU platform device is invalid\n");

		pr_err("VPU platform device is invalid\n");

		return -EINVAL;

	}



	dev = &pdev->dev;



	vpu = platform_get_drvdata(pdev);

	run = &vpu->run;