Commit 99f9cd2e authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

media: platform: renesas-ceu: drop buf NULL check 



Since start_streaming is only called if there are at least two
buffers queued, the ceudev->capture list will never be empty, so
the check whether there are no buffers can be dropped.

Note that the '!buf' check was wrong in any case, if we wanted to
check for an empty list it should have used list_empty().

This fixes this smatch warning:

drivers/media/platform/renesas/renesas-ceu.c:705 ceu_start_streaming() warn: can 'buf' even be NULL?

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Reviewed-by: default avatarJacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 7cc47111

drivers/media/platform/renesas/renesas-ceu.c

+0 −9
Original line number Diff line number Diff line
@@ -702,12 +702,6 @@ static int ceu_start_streaming(struct vb2_queue *vq, unsigned int count) 
	/* Grab the first available buffer and trigger the first capture. */

	buf = list_first_entry(&ceudev->capture, struct ceu_buffer,

			       queue);

	if (!buf) {

		spin_unlock_irqrestore(&ceudev->lock, irqflags);

		dev_dbg(ceudev->dev,

			"No buffer available for capture.\n");

		goto error_stop_sensor;

	}



	list_del(&buf->queue);

	ceudev->active = &buf->vb;
@@ -722,9 +716,6 @@ static int ceu_start_streaming(struct vb2_queue *vq, unsigned int count) 


	return 0;



error_stop_sensor:

	v4l2_subdev_call(v4l2_sd, video, s_stream, 0);



error_return_bufs:

	spin_lock_irqsave(&ceudev->lock, irqflags);

	list_for_each_entry(buf, &ceudev->capture, queue)