Commit 3d7c799c authored by NeilBrown's avatar NeilBrown Committed by Zheng Zengkai
Browse files

net: fix iteration for sctp transport seq_files



stable inclusion
from stable-5.10.17
commit c9013813413e12c8968e22964e314841b93af3c5
bugzilla: 48169

--------------------------------

commit af8085f3 upstream.

The sctp transport seq_file iterators take a reference to the transport
in the ->start and ->next functions and releases the reference in the
->show function.  The preferred handling for such resources is to
release them in the subsequent ->next or ->stop function call.

Since Commit 1f4aace6 ("fs/seq_file.c: simplify seq_file iteration
code and interface") there is no guarantee that ->show will be called
after ->next, so this function can now leak references.

So move the sctp_transport_put() call to ->next and ->stop.

Fixes: 1f4aace6 ("fs/seq_file.c: simplify seq_file iteration code and interface")
Reported-by: default avatarXin Long <lucien.xin@gmail.com>
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
Acked-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarZheng Zengkai <zhengzengkai@huawei.com>
Acked-by: default avatarXie XiuQi <xiexiuqi@huawei.com>
parent b670ad4e
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment