Commit 3cfae36c authored by Pavel Skripkin's avatar Pavel Skripkin Committed by Jinjiang Tu
Browse files

Input: appletouch - initialize work before device registration

mainline inclusion
from mainline-v5.16-rc8
commit 9f3ccdc3
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/I947RI
CVE: CVE-2021-46932

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9f3ccdc3f6ef10084ceb3a47df0961bec6196fd0



--------------------------------

Syzbot has reported warning in __flush_work(). This warning is caused by
work->func == NULL, which means missing work initialization.

This may happen, since input_dev->close() calls
cancel_work_sync(&dev->work), but dev->work initalization happens _after_
input_register_device() call.

So this patch moves dev->work initialization before registering input
device

Fixes: 5a6eb676 ("Input: appletouch - improve powersaving for Geyser3 devices")
Reported-and-tested-by: default avatar <syzbot+b88c5eae27386b252bbd@syzkaller.appspotmail.com>
Signed-off-by: default avatarPavel Skripkin <paskripkin@gmail.com>
Link: https://lore.kernel.org/r/20211230141151.17300-1-paskripkin@gmail.com


Cc: stable@vger.kernel.org
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarJinjiang Tu <tujinjiang@huawei.com>
parent 415aa2f1
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment