Commit 3caa2142 authored by Philipp Hortmann's avatar Philipp Hortmann Committed by Greg Kroah-Hartman
Browse files

staging: rtl8192e: Remove entry .rx_check_stuc.. from struct rtl819x_ops



Remove entry .rx_check_stuck_handler and replace it with function name
rtl92e_is_rx_stuck. This increases readability of the code.

Signed-off-by: default avatarPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/6538f1e158664837f6d1e7a20583ff20fc4f1403.1677010997.git.philipp.g.hortmann@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e1ac4b67
Loading
Loading
Loading
Loading
+1 −4
Original line number Diff line number Diff line
@@ -30,7 +30,6 @@ static const struct rtl819x_ops rtl819xp_ops = {
	.link_change			= rtl92e_link_change,
	.rx_command_packet_handler = NULL,
	.irq_clear			= rtl92e_clear_irq,
	.rx_check_stuck_handler	= rtl92e_is_rx_stuck,
};

static struct pci_device_id rtl8192_pci_id_tbl[] = {
@@ -1063,9 +1062,7 @@ static enum reset_type _rtl92e_tx_check_stuck(struct net_device *dev)

static enum reset_type _rtl92e_rx_check_stuck(struct net_device *dev)
{
	struct r8192_priv *priv = rtllib_priv(dev);

	if (priv->ops->rx_check_stuck_handler(dev))
	if (rtl92e_is_rx_stuck(dev))
		return RESET_TYPE_SILENT;

	return RESET_TYPE_NORESET;
+0 −1
Original line number Diff line number Diff line
@@ -211,7 +211,6 @@ struct rtl819x_ops {
					  struct sk_buff *skb,
					  struct rx_desc *pdesc);
	void (*irq_clear)(struct net_device *dev);
	bool (*rx_check_stuck_handler)(struct net_device *dev);
};

struct r8192_priv {