Commit e1ac4b67 authored by Philipp Hortmann's avatar Philipp Hortmann Committed by Greg Kroah-Hartman
Browse files

staging: rtl8192e: Remove entry .tx_check_stuc.. from struct rtl819x_ops 



Remove entry .tx_check_stuck_handler and replace it with function name
rtl92e_is_tx_stuck. This increases readability of the code.

Signed-off-by: default avatarPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/f58cc7b39f4a6bce0606bdd90a706b35b87d8256.1677010997.git.philipp.g.hortmann@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 302c42c5

drivers/staging/rtl8192e/rtl8192e/rtl_core.c

+1 −2
Original line number Diff line number Diff line
@@ -30,7 +30,6 @@ static const struct rtl819x_ops rtl819xp_ops = { 
	.link_change			= rtl92e_link_change,

	.rx_command_packet_handler = NULL,

	.irq_clear			= rtl92e_clear_irq,

	.tx_check_stuck_handler	= rtl92e_is_tx_stuck,

	.rx_check_stuck_handler	= rtl92e_is_rx_stuck,

};
@@ -1055,7 +1054,7 @@ static enum reset_type _rtl92e_tx_check_stuck(struct net_device *dev) 
	spin_unlock_irqrestore(&priv->irq_th_lock, flags);



	if (bCheckFwTxCnt) {

		if (priv->ops->tx_check_stuck_handler(dev))

		if (rtl92e_is_tx_stuck(dev))

			return RESET_TYPE_SILENT;

	}

drivers/staging/rtl8192e/rtl8192e/rtl_core.h

+0 −1
Original line number Diff line number Diff line
@@ -211,7 +211,6 @@ struct rtl819x_ops { 
					  struct sk_buff *skb,

					  struct rx_desc *pdesc);

	void (*irq_clear)(struct net_device *dev);

	bool (*tx_check_stuck_handler)(struct net_device *dev);

	bool (*rx_check_stuck_handler)(struct net_device *dev);

};