Commit 3c9ba81d authored by Kuniyuki Iwashima's avatar Kuniyuki Iwashima Committed by David S. Miller
Browse files

net: Fix a data-race around sysctl_somaxconn. 



While reading sysctl_somaxconn, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 05e49cfc

net/socket.c

+1 −1
Original line number Diff line number Diff line
@@ -1801,7 +1801,7 @@ int __sys_listen(int fd, int backlog) 


	sock = sockfd_lookup_light(fd, &err, &fput_needed);

	if (sock) {

		somaxconn = sock_net(sock->sk)->core.sysctl_somaxconn;

		somaxconn = READ_ONCE(sock_net(sock->sk)->core.sysctl_somaxconn);

		if ((unsigned int)backlog > somaxconn)

			backlog = somaxconn;