Commit 05e49cfc authored by Kuniyuki Iwashima's avatar Kuniyuki Iwashima Committed by David S. Miller
Browse files

net: Fix a data-race around netdev_unregister_timeout_secs. 



While reading netdev_unregister_timeout_secs, it can be changed
concurrently.  Thus, we need to add READ_ONCE() to its reader.

Fixes: 5aa3afe1 ("net: make unregister netdev warning timeout configurable")
Signed-off-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Acked-by: default avatarDmitry Vyukov <dvyukov@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8db24af3

net/core/dev.c

+1 −1
Original line number Diff line number Diff line
@@ -10284,7 +10284,7 @@ static struct net_device *netdev_wait_allrefs_any(struct list_head *list) 
				return dev;



		if (time_after(jiffies, warning_time +

			       netdev_unregister_timeout_secs * HZ)) {

			       READ_ONCE(netdev_unregister_timeout_secs) * HZ)) {

			list_for_each_entry(dev, list, todo_list) {

				pr_emerg("unregister_netdevice: waiting for %s to become free. Usage count = %d\n",

					 dev->name, netdev_refcnt_read(dev));