Commit 3b8a23ae authored by Philip Yang's avatar Philip Yang Committed by Alex Deucher
Browse files

drm/amdkfd: restore userptr ignore bad address error 



The userptr can be unmapped by application and still registered to
driver, restore userptr work return user pages will get -EFAULT bad
address error. Pretend this error as succeed. GPU access this userptr
will have VM fault later, it is better than application soft hangs with
stalled user mode queues.

v2: squash in warning fix (Alex)

Signed-off-by: default avatarPhilip Yang <Philip.Yang@amd.com>
Reviewed-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 68daadf3

drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c

+17 −10
Original line number Diff line number Diff line
@@ -2041,18 +2041,25 @@ static int update_invalid_user_pages(struct amdkfd_process_info *process_info, 
		/* Get updated user pages */

		ret = amdgpu_ttm_tt_get_user_pages(bo, bo->tbo.ttm->pages);

		if (ret) {

			pr_debug("%s: Failed to get user pages: %d\n",

				__func__, ret);

			pr_debug("Failed %d to get user pages\n", ret);



			/* Return error -EBUSY or -ENOMEM, retry restore */

			/* Return -EFAULT bad address error as success. It will

			 * fail later with a VM fault if the GPU tries to access

			 * it. Better than hanging indefinitely with stalled

			 * user mode queues.

			 *

			 * Return other error -EBUSY or -ENOMEM to retry restore

			 */

			if (ret != -EFAULT)

				return ret;

		}

		} else {



			/*

			 * FIXME: Cannot ignore the return code, must hold

			 * notifier_lock

			 */

			amdgpu_ttm_tt_get_user_pages_done(bo->tbo.ttm);

		}



		/* Mark the BO as valid unless it was invalidated

		 * again concurrently.

drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

+3 −0
Original line number Diff line number Diff line
@@ -696,6 +696,9 @@ int amdgpu_ttm_tt_get_user_pages(struct amdgpu_bo *bo, struct page **pages) 
				       true, NULL);

out_unlock:

	mmap_read_unlock(mm);

	if (r)

		pr_debug("failed %d to get user pages 0x%lx\n", r, start);



	mmput(mm);



	return r;