Commit 3b79ae61 authored Oct 14, 2021 by Jiapeng Chong Committed by Zheng Zengkai Oct 15, 2021

RDMA/cxgb4: Fix missing error code in create_qp()

stable inclusion
from stable-5.10.51
commit 313d9f25804c0024568f8863ec48f25a273e14c9
bugzilla: 175263 https://gitee.com/openeuler/kernel/issues/I4DT6F

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=313d9f25804c0024568f8863ec48f25a273e14c9

--------------------------------

[ Upstream commit aeb27bb7 ]

The error code is missing in this code scenario so 0 will be returned. Add
the error code '-EINVAL' to the return value 'ret'.

Eliminates the follow smatch warning:

drivers/infiniband/hw/cxgb4/qp.c:298 create_qp() warn: missing error code 'ret'.

Link: https://lore.kernel.org/r/1622545669-20625-1-git-send-email-jiapeng.chong@linux.alibaba.com


Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Chen Jun <chenjun102@huawei.com>
Acked-by: Weilong Chen <chenweilong@huawei.com>
Signed-off-by: Chen Jun <chenjun102@huawei.com>
Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>

parent 775e1fe3

drivers/infiniband/hw/cxgb4/qp.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -295,6 +295,7 @@ static int create_qp(struct c4iw_rdev rdev, struct t4_wq wq,
		if (user && (!wq->sq.bar2_pa \|\| (need_rq && !wq->rq.bar2_pa))) {
		pr_warn("%s: sqid %u or rqid %u not in BAR2 range\n",
		pci_name(rdev->lldi.pdev), wq->sq.qid, wq->rq.qid);
		ret = -EINVAL;
		goto free_dma;
		}